<html>
<head><meta charset="utf-8"><title>Team pull request · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html">Team pull request</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="243687197"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243687197" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jacob Lifshay <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243687197">(Jun 23 2021 at 17:43)</a>:</h4>
<p>Can someone look at <a href="https://github.com/rust-lang/team/pull/582">https://github.com/rust-lang/team/pull/582</a> iirc <span class="user-mention" data-user-id="281757">@Jubilee</span> sounded like she is ok with it last time I brought it up at the project-portable-simd meeting</p>



<a name="243687409"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243687409" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243687409">(Jun 23 2021 at 17:44)</a>:</h4>
<p>only the core team can merge these PRs</p>



<a name="243687681"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243687681" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jacob Lifshay <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243687681">(Jun 23 2021 at 17:46)</a>:</h4>
<p><span class="user-mention" data-user-id="132040">@Manish Goregaokar</span> is the one who's been merging stuff</p>



<a name="243698855"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243698855" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243698855">(Jun 23 2021 at 19:12)</a>:</h4>
<p><span class="user-mention" data-user-id="229517">@Jacob Lifshay</span> I need the team lead to approve the PR</p>



<a name="243698871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243698871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243698871">(Jun 23 2021 at 19:12)</a>:</h4>
<p>so ask Jubilee</p>



<a name="243699318"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243699318" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243699318">(Jun 23 2021 at 19:16)</a>:</h4>
<p>to be a bit more clear here, <span class="user-mention silent" data-user-id="281757">Jubilee</span> would need to approve the addition by leaving a comment on the PR itself :)</p>



<a name="243729903"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243729903" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jacob Lifshay <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243729903">(Jun 24 2021 at 00:27)</a>:</h4>
<p>ok, so her having already upvoted the top comment on that pull request is insufficient. <span class="user-mention" data-user-id="281757">@Jubilee</span> please fix that</p>



<a name="243731169"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243731169" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jubilee <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243731169">(Jun 24 2021 at 00:54)</a>:</h4>
<p>Ah!</p>



<a name="243731269"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243731269" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jubilee <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243731269">(Jun 24 2021 at 00:56)</a>:</h4>
<p>(deleted)</p>



<a name="243732079"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243732079" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243732079">(Jun 24 2021 at 01:12)</a>:</h4>
<p>what does "libcall legalize" mean?</p>



<a name="243732279"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243732279" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jacob Lifshay <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243732279">(Jun 24 2021 at 01:16)</a>:</h4>
<p>it's where LLVM converts a call to, for example, LLVM's vector sin intrinsic <code>llvm.sin.v4f32</code> to a call to a math library, I'm currently writing a vector math library that will hopefully get included in <code>core</code>: <a href="https://github.com/rust-lang/stdsimd/issues/109">stdsimd#109</a></p>



<a name="243732307"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243732307" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jacob Lifshay <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243732307">(Jun 24 2021 at 01:17)</a>:</h4>
<p>e.g. LLVM will currently convert math intrinsic calls to calls to Sleef, where Sleef is available and enabled.</p>



<a name="243732379"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243732379" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243732379">(Jun 24 2021 at 01:18)</a>:</h4>
<p>Gotcha. Why does it do that?</p>
<p>(sorry if this is off topic, happy to move to another thread)</p>



<a name="243732495"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243732495" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jacob Lifshay <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243732495">(Jun 24 2021 at 01:21)</a>:</h4>
<p>it's a mechanism where LLVM will either generate the native instructions for <code>sin</code> or will convert those to calls to a math library (perhaps by scalarizing), otherwise LLVM doesn't know how to calculate <code>sin</code>, so compilation will fail.</p>



<a name="243732580"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243732580" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jacob Lifshay <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243732580">(Jun 24 2021 at 01:23)</a>:</h4>
<p>The general idea of <a href="https://github.com/rust-lang/stdsimd/issues/109">stdsimd#109</a> is that Rust would gain a vector math library that's always available on all platforms that can be used when there aren't native instructions, allowing project-portable-simd to provide a vector sin function.</p>



<a name="243732823"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243732823" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243732823">(Jun 24 2021 at 01:28)</a>:</h4>
<p>ah I see, not all platforms have a <code>sin</code> intrinsic so they need it in software</p>



<a name="243734124"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243734124" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jacob Lifshay <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243734124">(Jun 24 2021 at 01:57)</a>:</h4>
<p>Thanks all!</p>



<a name="243738604"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/Team%20pull%20request/near/243738604" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Thom Chiovoloni <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/Team.20pull.20request.html#243738604">(Jun 24 2021 at 03:45)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/122651-general/topic/Team.20pull.20request/near/243732823">said</a>:</p>
<blockquote>
<p>ah I see, not all platforms have a <code>sin</code> intrinsic so they need it in software</p>
</blockquote>
<p>most do not, in fact. Or, x86/x86_64 does, but not one you want to use.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>